Skip to content

Conversation

@ErjieWu
Copy link
Collaborator

@ErjieWu ErjieWu commented Mar 21, 2025

Linked Issue

Solve #6031

Unit Tests and/or Case Tests for my changes

  • Reopen unit test for DeePKS multi-k case. It changes some output format compared to the old reference in 604_NO_deepks_ut_H2O_multik test case. Add some more reference files for functions checking which are related to stress calculation in DeePKS.
  • Since the calculation of projected density matrix (pdm) is changed slightly, some of the integrate test cases are influenced. They are 602_NO_deepks_d_H2O_md_lda2pbe, 603_NO_deepks_H2O_bandgap and 603_NO_deepks_H2O_multik.

What's changed?

  • The calculation of pdm in function cal_pdm() has been changed. In the old version, It used DMR to calculate pdm and lost some messages since HContainer object of DMR did not save all required data for DeePKS usage. After this pr it will be changed to be calculated by DMK, which will reserve these lost messages.
  • Add default values to control threshold and precision for Output_HContainer.

@mohanchen mohanchen added Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes Machine Learning Issues related to the DeePKS labels Mar 22, 2025
@mohanchen mohanchen merged commit 924d29d into deepmodeling:develop Mar 25, 2025
14 checks passed
@ErjieWu ErjieWu deleted the refactor branch March 25, 2025 07:33
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
* Add default threshold and precision value for Output_HContainer.

* Reopen DeePKS multi-k unittest.

* Update multi-k ut in DeePKS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT Machine Learning Issues related to the DeePKS Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants